Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add additional node info to testing #2521

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

jonathan-innis
Copy link
Contributor

Fixes #

Description

  • Add additional node info in testing for BeforeEach
  • Bump upgrade tests to v0.16.1 where we have fixed test flakiness

How was this change tested?

  • make test
  • TEST_FILTER=Integration make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@jonathan-innis jonathan-innis requested a review from a team as a code owner September 16, 2022 18:08
@netlify
Copy link

netlify bot commented Sep 16, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 546a674
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6324bc00fa0184000a86e11b

Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I would hesitate on bumping the old test version up but probably worth it at this point to get the upgrade suite running non-flakey.

@jonathan-innis
Copy link
Contributor Author

lgtm, I would hesitate on bumping the old test version up but probably worth it at this point to get the upgrade suite running non-flakey.

Yeah, the tests weren't even testing the upgrade scenario before anyways because they were failing on the first set of tests so better to de-flake.

@jonathan-innis jonathan-innis merged commit c201b33 into aws:main Sep 16, 2022
@jonathan-innis jonathan-innis deleted the node-info branch September 16, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants