Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix pod preemption in kubelet config tests #2531

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Sep 19, 2022

Fixes #

Description

  • Fix pod preemption in kubelet config testing by moving from creation of static Pod to Deployment
  • Adds event logging for pods after the test is completed

How was this change tested?

  • TEST_FILTER=Integration make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, something went wrong.

@jonathan-innis jonathan-innis requested a review from a team as a code owner September 19, 2022 19:40
@netlify
Copy link

netlify bot commented Sep 19, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 5293ea6
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6328c8cc183f4d000889abd8

@jonathan-innis jonathan-innis force-pushed the fix-pod-preemption branch 5 times, most recently from aacc4fb to f9c3441 Compare September 19, 2022 19:50
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathan-innis jonathan-innis merged commit 1e00020 into aws:main Sep 19, 2022
@jonathan-innis jonathan-innis deleted the fix-pod-preemption branch September 19, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants