Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(parameters): types in BaseProvider + added getMultiple alias to SecretsProvider #1214

Merged
merged 1 commit into from Jan 5, 2023
Merged

refactor(parameters): types in BaseProvider + added getMultiple alias to SecretsProvider #1214

merged 1 commit into from Jan 5, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR removes the method overrides from the get and getMultiple methods in the BaseProvider so that children classes can set their own types on these methods. See #1213 for full details.

How to verify this change

See existing checks under the PR.

Related issues, RFCs

Issue number: #1213

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Jan 5, 2023
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Jan 5, 2023
@dreamorosi dreamorosi changed the title fix: types in BaseProvider + added getMultiple alias to SecretsProvider refactor: types in BaseProvider + added getMultiple alias to SecretsProvider Jan 5, 2023
@github-actions github-actions bot added bug Something isn't working feature PRs that introduce new features or minor changes labels Jan 5, 2023
@dreamorosi dreamorosi added parameters This item relates to the Parameters Utility and removed bug Something isn't working labels Jan 5, 2023
@dreamorosi dreamorosi merged commit 32bd7e8 into main Jan 5, 2023
@dreamorosi dreamorosi deleted the chore/parameters/types branch January 5, 2023 19:31
@dreamorosi dreamorosi changed the title refactor: types in BaseProvider + added getMultiple alias to SecretsProvider refactor(parameters): types in BaseProvider + added getMultiple alias to SecretsProvider Jan 5, 2023
@dreamorosi dreamorosi linked an issue Jan 5, 2023 that may be closed by this pull request
Maintenance: Remove overrides from Parameters' BaseProvider #1213
Closed
2 tasks
@dreamorosi dreamorosi mentioned this pull request Jan 5, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dreamorosi dreamorosi

Labels
feature PRs that introduce new features or minor changes parameters This item relates to the Parameters Utility size/S PR between 10-29 LOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance: Remove overrides from Parameters' BaseProvider
1 participant
@dreamorosi