Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(layers): bump hardcoded cdk version in publish_layer.yaml #1232

Merged
merged 1 commit into from Jan 13, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As described in #1231, the publish_layer.yaml workflow contains an hardcoded version for the CDK CLI. Given that the CDK version in the project was recently updated, the version in the workflow and the one on the project were now out of sync.

As a short term solution to be able to publish the layers, this PR bumps the version and leaves it hardcoded.

I have written down the task to remove the hardcoded version in favor of using the one installed in the project, and managed in the package.json of the layer-publisher folder, in #1226.

How to verify this change

Related issues, RFCs

Issue number: #1231

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Jan 13, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jan 13, 2023
@dreamorosi dreamorosi merged commit 63a3909 into main Jan 13, 2023
@dreamorosi dreamorosi deleted the fix/layers/cli_version branch January 13, 2023 10:49
@dreamorosi dreamorosi added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jan 13, 2023
@dreamorosi dreamorosi linked an issue Jan 13, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: bump CDK CLI version in publish_layer.yaml workflow
1 participant