Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layers): add new regions #1322

Merged
merged 5 commits into from Feb 23, 2023
Merged

feat(layers): add new regions #1322

merged 5 commits into from Feb 23, 2023

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Feb 22, 2023

Description of your changes

I have added three new regions:

  • eu-south-2
  • eu-central-2
  • ap-southeast-4

in test and prod accounts. I have also bumped the layer version to the same level, current level 8.

I had to fix the pre-push hook, otherwise I couldn't create the PR.

How to verify this change

Related issues, RFCs

Issue number: #1169

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Feb 22, 2023
@github-actions github-actions bot added the feature PRs that introduce new features or minor changes label Feb 22, 2023
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR Alex, could you please also update the docs with the new ARNs (both versions & new regions)?

@dreamorosi
Copy link
Contributor

Also could you please document under this PR the high level steps needed to onboard a new region, aside from the ones in the diff? I.e. CDK bootstrap the new region, etc.

This way next time if you are not available another maintainer can do it.

@pull-request-size pull-request-size bot added size/M PR between 30-99 LOC and removed size/S PR between 10-29 LOC labels Feb 23, 2023
@dreamorosi
Copy link
Contributor

We have the layer version also at the following lines of the main page: L29, 77, 108, 140, 192, 210, 234, 244, 250

@pull-request-size pull-request-size bot added size/L PRs between 100-499 LOC and removed size/M PR between 30-99 LOC labels Feb 23, 2023
@am29d
Copy link
Contributor Author

am29d commented Feb 23, 2023

Added docs. Surprisingly, many regions undocumented existed before, so it does look like we added more regions.

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this Alex, appreciate it!

And good spot for the missing regions!

@dreamorosi dreamorosi merged commit 618613b into aws-powertools:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature PRs that introduce new features or minor changes size/L PRs between 100-499 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Lambda Layer support for new regions eu-central-2 & eu-south-2
2 participants