Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parameters): handle base64/binaries in transformer #1326

Merged
merged 1 commit into from Feb 22, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As described in #1325, the current implementation of the transformer in the Parameters utility was not handling correctly values returned by AppConfig, which are always of type Uint8Array.

The linked issue has a more in-depth explanation, but essentially this PR updates the transformer so that both json and binary (aka base64) transforms can be used correctly with the provider.

Once merged this PR will close #1325.

How to verify this change

See checks below the PR as well as successful integration tests run here.

Related issues, RFCs

Issue number: #1325

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Feb 22, 2023
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Feb 22, 2023
@github-actions github-actions bot added the bug Something isn't working label Feb 22, 2023
@dreamorosi dreamorosi merged commit bb50c04 into main Feb 22, 2023
@dreamorosi dreamorosi deleted the fix/parameters/transforms branch February 22, 2023 17:01
@dreamorosi dreamorosi added the parameters This item relates to the Parameters Utility label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parameters This item relates to the Parameters Utility size/L PRs between 100-499 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: transform not handling base64/binary values correctly
1 participant