Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SdkBody implements http-body = 1.0 via a shim #1046

Open
Tracked by #977
rcoh opened this issue Jan 16, 2024 · 0 comments
Open
Tracked by #977

SdkBody implements http-body = 1.0 via a shim #1046

rcoh opened this issue Jan 16, 2024 · 0 comments
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@rcoh
Copy link
Contributor

rcoh commented Jan 16, 2024 •
edited

@cayman-amzn
@rcoh rcoh mentioned this issue Jan 16, 2024
Open
11 tasks
@cayman-amzn cayman-amzn mentioned this issue Jan 20, 2024
Merged
2 tasks
github-merge-queue bot pushed a commit to smithy-lang/smithy-rs that referenced this issue Feb 28, 2024
@cayman-amzn @rcoh @jdisanti
feat(aws-smithy-types): Impl http-body-1.0 Body for SdkBody (#3380)
d42727e 
## Motivation and Context
A step towards moving to http-1.0
awslabs/aws-sdk-rust#1046

(Russell): This is a minimal implementation of `http-body = 1`. It isn't
maximally efficient since even if we were given a 1x body, we convert it
back and forth first. This is a first step.

## Description
Implements http-body-1.0 Body trait for SdkBody.

## Testing
Regular CI

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: Russell Cohen <rcoh@amazon.com>
Co-authored-by: Russell Cohen <russell.r.cohen@gmail.com>
Co-authored-by: John DiSanti <john@vinylsquid.com>
Co-authored-by: John DiSanti <jdisanti@amazon.com>
@rcoh rcoh added feature-request A feature should be added or improved. p2 This is a standard priority issue labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcoh