Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated crates suggest to use deprecated aws_config::load_from_env #1088

Open
mchoicpe-amazon opened this issue Mar 4, 2024 · 1 comment
Labels
documentation This is a problem with documentation p2 This is a standard priority issue

Comments

@mchoicpe-amazon
Copy link
Contributor

Describe the issue

https://docs.rs/aws-sdk-appconfigdata/latest/aws_sdk_appconfigdata/client/index.html

Suggests the following:

let config = aws_config::load_from_env().await;
let client = aws_sdk_appconfigdata::Client::new(&config);

Not sure if this was intentional, but load_from_env is deprecated by default (behavior-version-latest disabled by default). The documentation should change to suggest construction like so:

let config = aws_config::load_from_env().await;
let client = aws_sdk_appconfigdata::Client::new(&config);

Alternative the doc could inform users the feature flag is required to make the example work.

Links

https://docs.rs/aws-sdk-appconfigdata/latest/aws_sdk_appconfigdata/client/index.html
https://docs.rs/aws-config/1.1.7/aws_config/fn.load_from_env.html

@mchoicpe-amazon mchoicpe-amazon added documentation This is a problem with documentation needs-triage This issue or PR still needs to be triaged. labels Mar 4, 2024
@jdisanti jdisanti added p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Mar 7, 2024
@jdisanti
Copy link
Contributor

jdisanti commented Mar 7, 2024

Thanks for filing this. I think we just need to switch it over to calling load_defaults with BehaviorVersion::latest() instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants