Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: num2str: support Z/Zi Y/Yi unit #1715

Closed
wants to merge 1 commit into from
Closed

feat: num2str: support Z/Zi Y/Yi unit #1715

wants to merge 1 commit into from

Conversation

mokurin000
Copy link

@mokurin000 mokurin000 commented Feb 3, 2024 •
edited

Please confirm that your commit message(s) follow these guidelines:

  • 1. First line is a commit title, a descriptive one-liner for the change
  • 2. Empty second line
  • 3. Commit message body that explains why the change is useful. Break lines that are't something like a URL at 72-74 chars.
  • 4. Empty line
  • 5. Signed-off-by: Real Name real@email.com

close #1714

@mokurin000
feat: num2str, support Z/Zi and Y/Yi
d02a078 
num2str does supports units below Z/Zi, but it's no bad to be comfortable with unbelievable unit

Signed-off-by: poly000 <1348292515a@gmail.com>
@mokurin000
Copy link
Author

just realized that it's useless for a uint64_t intepreter to support units above EB
and not every platform supports 128-bit integer natively

@mokurin000 mokurin000 closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Zi/Z, Yi/Y in num2str
1 participant
@mokurin000