Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One place memory leak #1752

Open
lynnux opened this issue Apr 17, 2024 · 1 comment
Open

One place memory leak #1752

lynnux opened this issue Apr 17, 2024 · 1 comment

Comments

@lynnux
Copy link

lynnux commented Apr 17, 2024

curl_slist_free_all(slist);

the slist passed into _add_aws_auth_header, it's realloced by curl_slist_append , but in fio_http_queue the slist always 0.

@vincentkfu
Copy link
Collaborator

vincentkfu commented Apr 19, 2024

What do you think is the best fix?

slist does not need to be passed to _add_aws_auth_header or _add_swift_header. It seems to me that the least intrusive fix would be to have those two functions return slist and then curl_slist_free_all will have a non-null parameter.

Feel free to send a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants