-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConfigParser is not a constructor #41
Comments
@afterbangx Can you send in a PR with this ? @jahnavi310 also has this issue. @jahnavi310 are you aware of this change ? |
Sure thing. I'll send it in a bit. |
* fix for ConfigParser is not a constructor error supports protractor 4.x.x * fix for #41 ConfigParser is not a constructor error
I am still getting this error . protractor --version protractor-perf --version |
I see this error too. PATH_TO_MY_PROJECT/node_modules/protractor-perf/lib/cli.js:146 "protractor": "^4.0.13" |
Thanks for identifying the issue, this solved for me. My versions are: @axemclion do you intend to add it to the new version? Is there any pending issue regarding this? I thought about keeping compatibility with old versions:
Henrique. |
@henriquelbsouza I do want to add it to the new issue. Can you send in a PR and I can merge it in and publish a new version ? |
@axemclion sure, give me a moment. |
@axemclion this is created, I wasn't able to run Just make sure that my changes didn't broke anything :P Thanks for the fast answer by the way ;) |
@henriquelbsouza The npm tests require saucelabs credentials, so they only run on master unfortunately. I merged in the PR - thanks a lot for the work !! |
@axemclion @henriquelbsouza , protractor: 5.1.1 |
I just installed this library today and ran into a problem with Protractor 4.0.9. When I tried to run
protractor-perf
it was throwing the errorI changed line 145 in cli.js from
var ConfigParser = require('protractor/built/configParser').default;
tovar ConfigParser = require('protractor/built/configParser').ConfigParser;
It started running for me after I made this change. Should I have to do this to get it to work? Am I missing something else? Or is it just a breaking change with ptor 4+?
The text was updated successfully, but these errors were encountered: