Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make New Public Again #32

Open
jayaprabhakar opened this issue Dec 14, 2022 · 0 comments
Open

Make New Public Again #32

jayaprabhakar opened this issue Dec 14, 2022 · 0 comments
Assignees
Milestone

Comments

@jayaprabhakar
Copy link

The public constructors at present allow only 14 or 16 registers.

func New() *Sketch
func New14() *Sketch
func New16() *Sketch
func New16NoSparse() *Sketch

The private constructor newSketch looks like it can take between 4-18 registers, and also a flag to say sparse or normal.

Looking at the commit history, the public constructor was removed in commit dba7ba9

Do you see any fundamental issue with the reduced bases? Is it possible to allow those again?

I have a use case where I need to maintain a large number of these HLL sketches, that can tolerate a higher error rate as well. So I am planning to use just 4 or 8 registers.

@lukasmalkmus lukasmalkmus added this to the v1.0.0 milestone Feb 1, 2023
cgray pushed a commit to cgray/hyperloglog that referenced this issue May 1, 2023
Adds the ability to create a spare or non-sparse hll graph of the
provided precision via the hyperloglog::NewSketch function.
Provides capabilities requested in  axiomhq#32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants