From e6f7053bf1a3e87cf1f9da8677e12e3fe829d68e Mon Sep 17 00:00:00 2001 From: Dmitriy Mozgovoy Date: Wed, 26 Apr 2023 00:34:46 +0300 Subject: [PATCH] perf(merge-config): optimize mergeConfig performance by avoiding duplicate key visits; (#5679) --- lib/core/mergeConfig.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/core/mergeConfig.js b/lib/core/mergeConfig.js index 2aee6b895c..671e3345f6 100644 --- a/lib/core/mergeConfig.js +++ b/lib/core/mergeConfig.js @@ -95,7 +95,7 @@ export default function mergeConfig(config1, config2) { headers: (a, b) => mergeDeepProperties(headersToObject(a), headersToObject(b), true) }; - utils.forEach(Object.keys(config1).concat(Object.keys(config2)), function computeConfigValue(prop) { + utils.forEach(Object.keys(Object.assign({}, config1, config2)), function computeConfigValue(prop) { const merge = mergeMap[prop] || mergeDeepProperties; const configValue = merge(config1[prop], config2[prop], prop); (utils.isUndefined(configValue) && merge !== mergeDirectKeys) || (config[prop] = configValue);