Feature request: fetch based adapter #1219

ccnokes · 2017-12-04T17:09:50Z

I didn't see an issue for this (opened or closed), but if this is a duplicate just close it 😸 .

Are there any plans for a fetch based adapter for axios? I thought I'd check and see if this has been discussed, and if not, if you all would be open to a feature request (or I'm happy to work on it and PR it).

Reasons for adding a fetch adapter are basically for the same reasons you'd use fetch:

Support for service workers
Integration with Cache API
natively promise based, so axios can become a thinner library
response streaming
probably more that I'm not even thinking of right now

Reasons you'd still want axios wrapping fetch for you (because some people feel like you don't need a lib over fetch):

fetch is low level. Using plain fetch in an app that is 99% GET/PUT/POST against a JSON API means lots of duplicate boilerplate code which axios can abstract
request/response interceptors
probably more that I'm not even thinking of right now 😄

The text was updated successfully, but these errors were encountered:

mividtim · 2017-12-28T13:47:57Z

👍

jc275 · 2018-01-01T17:49:30Z

Agreed. This looks like a dealbreaker for using Axios in PWAs, because the serviceworker can only intercept and cache http requests sent via the fetch api.

Discussed in #484

jabacchetta · 2018-01-09T07:57:10Z

Just noticed this after diving into service workers this week. Is isomorphic-fetch a viable alternative for PWAs?

ccnokes · 2018-01-09T16:33:50Z

@jabacchetta I have no experience with PWAs yet but I would think so. If you want something sort of axios like, https://github.com/jackfranklin/so-fetch, looks good (haven't tried it yet personally though).

jabacchetta · 2018-01-09T21:58:24Z

Great, thanks! I'll take a look.

NShahri · 2018-01-11T02:44:03Z

Is there any implementation for 'fetch adapter' in progress? otherwise I can work on it

ccnokes · 2018-01-13T04:20:10Z

@NShahri I haven't started on anything yet, sadly ☹️

NShahri · 2018-01-14T19:44:15Z

@ccnokes Ok, I will send pull request soon

ccnokes · 2018-01-16T04:51:41Z

I actually just started working on this too (don't let this discourage you @NShahri, yours might be better or I might not finish it, etc).

Still hoping for some positive signal from a maintainer. @nickuraltsev or @mzabriskie any thoughts on this?

I haven't gotten too far into the implementation yet but I know one question that'll come up is do you explicitly opt into the fetch adapter or does it take precedence over the XMLHttpRequest one, if available? I'm sure more questions will come later 😄.

NShahri · 2018-01-16T10:00:55Z

@ccnokes, at the moment I change the code to choose fetch adapter when fetch is available otherwise it will choose XHR adapter.

Also I am using whatwg-fetch polyfill in test environment as it lets me to run the all current tests against fetch adapter with minimum changes. This polyfill uses XHR to implement fetch, so I can use it on test environment for running current XHR tests for fetch adapter. But I am no sure about this approach.

In addition I have another question about 'withCredentials' as I think it can be mapped to request.credentials which can accept 'include', 'omit' and 'same-origin' as value. I am not sure 'include' or 'same-origin' is the right value when withCredianls=true or should I change axios interface to let user to choose value except true or false.

@nickuraltsev @mzabriskie

I am working on 22 failed test to finalise the implementation and send pull request.

NShahri · 2018-01-16T11:27:04Z

@ccnokes this is my first try to implement fetch adapter https://github.com/axios/axios/compare/master...NShahri:feature/fetch-adapter?w=1

Remaining tasks:

Progress handlers (download and upload)
~~Setting timeout~~: When AbortController is supported by browser or polyfill
Check new timeout test: It is failing on xhr adapter
~~Abort~~: When AbortController is supported by browser or polyfill
Redirects
Use new implemented utils/enums in http and xhr adapter
Test bundle size
Passing all tests using polyfill
finalise tests for fetch
run tests for all xhr, http and fetch adapters

ccnokes · 2018-01-17T03:40:32Z

Nice @NShahri! Let me know if you need help with anything.

NShahri · 2018-01-17T04:02:46Z

Thanks @ccnokes, Feel free to start implementing any of remaining tasks. let me know which one you started to avoid both of us working on the same task.

ccnokes · 2018-01-24T03:58:53Z

Hey @NShahri sorry for the delay, I'll take a look this week at the Redirects task.

How should we do this? Should I fork/PR you or do you want me just committing directly to your fork?

NShahri · 2018-01-31T21:53:26Z

@ccnokes sorry for delay.
it is up to you fork/PR me or direct commiting

eybarta · 2018-04-18T08:39:35Z

Hey guys, any progress on this? I would LOVE to keep using axios, but I need to implement
offline availability with SW's, can I do anything to help?

thx

NShahri · 2018-04-18T20:10:00Z

@eybarta
Unfortunately I am too busy and can not finalise this feature.

The minimum requirements are implemented and tested, but I haven't use this in any app. It would be great if you have time and use it in your app. https://github.com/NShahri/axios/tree/feature/fetch-adapter

There is a list of remaining tasks in #1219 (comment).

NOTE:

there are some missing functionalities because it is not supported by fetch in some browsers like request timeout and progress handler
because of the differences between xhr and fetch, there are some functionality in fetch which is not implemented by axios, like credentials: 'same-origin'

Next phase to finalise fetch adapter would be changing axios interface to accept options which user can use to configure fetch request

rajatvijay · 2018-11-13T04:31:32Z

@NShahri

are all the remaining task done and released?
If not is it up for grabs?

ccnokes · 2018-11-14T03:50:10Z

Personally, I'd be wary of working on adding fetch support as a PR, especially as there hasn't been any interest shown from maintainers. Also I noticed there's a 1.0.0 version in the plans: https://github.com/axios/axios/projects/2. Maybe a fetch adapter will be a part of that?

Mechazawa · 2018-11-14T11:01:51Z

It'd be great if a fetch adapter can be part of 1.0.0. It'd solve a lot of issues I have with xhrAdapter.

juanarbol · 2019-01-09T04:32:50Z

@ccnokes This issue is already solved, close please.

Mechazawa · 2019-01-09T10:58:51Z

@juanarbol What PR was it fixed in? I can't find the fetch adapter in the codebase.

juanarbol · 2019-01-09T18:32:51Z

My bad, if anyone could explain me how to solve, I could help

cristianoccazinsp · 2019-04-07T18:00:26Z

Any news on this? When using react native, fetch seems to be way faster than xhr to process json responses and it would be great to use a fetch adapter.

pchaganti · 2019-04-07T18:12:24Z

👍

This changeset adds a `fetch`-based adapter implementation to `axios`, powered by `cross-fetch`[1]. The implementation may thus be used on either Node or in browser environments. Changes enclosed: - Add `fetch` adapter implementation - Add `fetch` to standard built-in adapters - Add initial Node-side tests for `fetch` - Slight refactor to tests to use common setup / teardown code Still pending: - Upload/download progress events - Browser-side testing Fixes and closes axios#1219, and supersedes axios#2891.

mh-alahdadian · 2022-10-18T04:52:57Z

As far as I know we can not have a upload progress percentage with fetch base technology , Are you going to implement a adapter without supporting upload progress feature ?

sgammon · 2022-10-18T05:16:54Z

@mh-alahdadian i haven't gotten that far yet. streams aren't yet standardized on the web platform but perhaps there is a high-quality polyfill or workaround.

in any case, i don't see why this would be a practical limitation. if you're in a browser environment, you can still use the XHR adapter, which supports the progress event (axios supports download and upload progress on top of XHR).

if you're in a node environment, you can use the http adapter, which also supports upload and download progress.

in more exotic environments like CloudFlare Workers, where you only have access to fetch, this may be an unsupported feature until the spec lands, only because the runtime may not emit the requisite events.

EDIT: @mh-alahdadian looks like ReadableStream is at 95% on caniuse and has high-quality polyfills, so i'll wire that in for the upload/download events in browser environments, if that's relevant to your needs. the upload side of it is still rather fresh in Chrome, so if it is even possible to land upload events in the browser, it will probably be hidden behind a flag.

KaKi87 · 2022-10-26T16:54:17Z

One more reason in favor of a fetch adapter is Deno support.

Thanks

This changeset adds a `fetch`-based adapter implementation to `axios`, powered by `cross-fetch`[1]. The implementation may thus be used on either Node or in browser environments. Changes enclosed: - Add `fetch` adapter implementation - Add `fetch` to standard built-in adapters - Add initial Node-side tests for `fetch` - Slight refactor to tests to use common setup / teardown code Still pending: - Upload/download progress events - Browser-side testing Fixes and closes axios#1219, and supersedes axios#2891.

TaxBusby · 2024-02-09T18:22:46Z

Another new JS runtime, llrt just came out, boasting low latency startups for serverless environments. It supports fetch but not http.request. So a fetch adapter would help support this runtime as well.

KaKi87 · 2024-02-09T18:31:19Z

For now I recommend @haverstack/axios-fetch-adapter.

sgammon · 2024-02-10T00:07:34Z

cc / @jasonsaayman I'd still love to join discord and attack this; let me know if that's welcome at all :)

This changeset adds a `fetch`-based adapter implementation to `axios`, powered by `cross-fetch`[1]. The implementation may thus be used on either Node or in browser environments. Changes enclosed: - Add `fetch` adapter implementation - Add `fetch` to standard built-in adapters - Add initial Node-side tests for `fetch` - Slight refactor to tests to use common setup / teardown code Still pending: - Upload/download progress events - Browser-side testing Fixes and closes axios#1219, and supersedes axios#2891.

DigitalBrainJS · 2024-04-29T17:04:32Z

Fetch adapter was added in v1.7.0-beta.0
Use npm i axios@next to install the beta.

Khaledgarbaya added feature labels Jan 30, 2018

dalyIsaac mentioned this issue Feb 27, 2018

Switch to fetch from XMLHttpRequest. dalyIsaac/onenote-markdown-old#14

Closed

Blfrg mentioned this issue Jul 25, 2018

XMLHttpRequest is discouraged #484

Closed

Mechazawa mentioned this issue Nov 14, 2018

Rewrite fetch to axios MapcreatorIO/api-wrapper#109

Merged

sgammon mentioned this issue Oct 17, 2022

feat(adapters): add fetch adapter #5146

Closed

59 tasks

jasonsaayman self-assigned this Oct 18, 2022

jasonsaayman reopened this Oct 18, 2022

saladbowl77 mentioned this issue Oct 22, 2022

axios非対応環境下でエラーが発生する Newt-Inc/newt-client-js#52

Closed

azu mentioned this issue Nov 5, 2022

refactor(ajax): Ajaxの章をリファクタリング asciidwango/js-primer#1519

Merged

cuibonobo mentioned this issue Nov 27, 2022

Square SDK is unusable in Cloudflare Workers square/square-nodejs-sdk#111

Closed

hansottowirtz mentioned this issue Dec 10, 2022

Using Mollie on Cloudflare Workers mollie/mollie-api-node#208

Open

sgammon mentioned this issue Dec 18, 2022

fetch http adapter #4965

Open

pauldraper mentioned this issue Jun 14, 2023

Cannot disable redirects with maxRedirects: 0 #3924

Closed

dmgardiner25 mentioned this issue Jul 7, 2023

Allow optional axios adapter in TunnelManagementHttpClient microsoft/dev-tunnels#271

Merged

1 task

swcm-mnestler mentioned this issue Jul 28, 2023

HTTP/2 support #1175

Open

jasonsaayman removed the feature label Aug 31, 2023

benmccann mentioned this issue Feb 1, 2024

PERF: switch from axios to fetch immich-app/immich#6647

Closed

3 tasks

suhaotian mentioned this issue Mar 4, 2024

The Modern Axios: Migrate to xior.js if you would like use fetch and why: liteweight, similar API to axios, and plugins support suhaotian/xior#7

Closed

DigitalBrainJS added the fetch label Apr 29, 2024

DigitalBrainJS closed this as completed Apr 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature request: fetch based adapter #1219

Feature request: fetch based adapter #1219

ccnokes commented Dec 4, 2017 •

edited

mividtim commented Dec 28, 2017

jc275 commented Jan 1, 2018 •

edited

jabacchetta commented Jan 9, 2018

ccnokes commented Jan 9, 2018

jabacchetta commented Jan 9, 2018

NShahri commented Jan 11, 2018

ccnokes commented Jan 13, 2018

NShahri commented Jan 14, 2018

ccnokes commented Jan 16, 2018

NShahri commented Jan 16, 2018 •

edited

NShahri commented Jan 16, 2018 •

edited

ccnokes commented Jan 17, 2018

NShahri commented Jan 17, 2018

ccnokes commented Jan 24, 2018 •

edited

NShahri commented Jan 31, 2018

eybarta commented Apr 18, 2018

NShahri commented Apr 18, 2018

rajatvijay commented Nov 13, 2018

ccnokes commented Nov 14, 2018 •

edited

Mechazawa commented Nov 14, 2018

juanarbol commented Jan 9, 2019

Mechazawa commented Jan 9, 2019 •

edited

juanarbol commented Jan 9, 2019

cristianoccazinsp commented Apr 7, 2019

pchaganti commented Apr 7, 2019

mh-alahdadian commented Oct 18, 2022

sgammon commented Oct 18, 2022 •

edited

KaKi87 commented Oct 26, 2022

TaxBusby commented Feb 9, 2024

KaKi87 commented Feb 9, 2024

sgammon commented Feb 10, 2024

DigitalBrainJS commented Apr 29, 2024

Feature request: fetch based adapter #1219

Feature request: fetch based adapter #1219

Comments

ccnokes commented Dec 4, 2017 • edited

mividtim commented Dec 28, 2017

jc275 commented Jan 1, 2018 • edited

jabacchetta commented Jan 9, 2018

ccnokes commented Jan 9, 2018

jabacchetta commented Jan 9, 2018

NShahri commented Jan 11, 2018

ccnokes commented Jan 13, 2018

NShahri commented Jan 14, 2018

ccnokes commented Jan 16, 2018

NShahri commented Jan 16, 2018 • edited

NShahri commented Jan 16, 2018 • edited

ccnokes commented Jan 17, 2018

NShahri commented Jan 17, 2018

ccnokes commented Jan 24, 2018 • edited

NShahri commented Jan 31, 2018

eybarta commented Apr 18, 2018

NShahri commented Apr 18, 2018

rajatvijay commented Nov 13, 2018

ccnokes commented Nov 14, 2018 • edited

Mechazawa commented Nov 14, 2018

juanarbol commented Jan 9, 2019

Mechazawa commented Jan 9, 2019 • edited

juanarbol commented Jan 9, 2019

cristianoccazinsp commented Apr 7, 2019

pchaganti commented Apr 7, 2019

mh-alahdadian commented Oct 18, 2022

sgammon commented Oct 18, 2022 • edited

KaKi87 commented Oct 26, 2022

TaxBusby commented Feb 9, 2024

KaKi87 commented Feb 9, 2024

sgammon commented Feb 10, 2024

DigitalBrainJS commented Apr 29, 2024

ccnokes commented Dec 4, 2017 •

edited

jc275 commented Jan 1, 2018 •

edited

NShahri commented Jan 16, 2018 •

edited

NShahri commented Jan 16, 2018 •

edited

ccnokes commented Jan 24, 2018 •

edited

ccnokes commented Nov 14, 2018 •

edited

Mechazawa commented Jan 9, 2019 •

edited

sgammon commented Oct 18, 2022 •

edited