Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With branch should I open an PR? #4890

Closed
WillianAgostini opened this issue Jul 27, 2022 · 5 comments
Closed

With branch should I open an PR? #4890

WillianAgostini opened this issue Jul 27, 2022 · 5 comments

Comments

@WillianAgostini
Copy link
Contributor

When a fix issue is opened from branch v1.x, should I make a PR for main, v1.x or both branches?

When has a feat issue, which branch must use to open an PR? Main branch?

With frequency created new releases are?

Some examples of open PR:
@jasonsaayman
Copy link
Member

Currently you can pull to v1 if there is a non-breaking change if you want to add a breaking change v2

@WillianAgostini
Copy link
Contributor Author

WillianAgostini commented Aug 1, 2022 •
edited

Thank @jasonsaayman, so...

Has a doc about this rule?
With frequency created new releases are?
Is the branch main used?

@jasonsaayman
Copy link
Member

No, I have not, in all honesty I have not yet had time to look into that stuff but I will try to do so asap

@WillianAgostini
Copy link
Contributor Author

I can help to discuss and define CONTRIBUTING.md docs.

@AbdlrahmanSaberAbdo
Copy link

Hi @jasonsaayman Regarding this PR #4850, should I re-open it in V1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasonsaayman @WillianAgostini @AbdlrahmanSaberAbdo