Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error wile parsing URL #5020

Closed
marsidorowicz opened this issue Oct 5, 2022 · 4 comments
Closed

Error wile parsing URL #5020

marsidorowicz opened this issue Oct 5, 2022 · 4 comments

Comments

@marsidorowicz
Copy link

marsidorowicz commented Oct 5, 2022

Describe the bug

Axios is not correctly parsing URL that is passed with question mark, it is skipping it
Question**

To Reproduce

Code snippet to reproduce, ideally that will work by pasting into something like https://npm.runkit.com/axios, a hosted solution, or a repository that illustrates the issue. If your problem is not reproducible, please file under Support or Usage Question

// Example code here
await axios.get(
				'https://xyz.com/api/account?acct=123",
				{
					headers: {
						'Content-Type': 'application/json',
						'OK-ACCESS-KEY': APIKEY,
						'OK-ACCESS-SIGN': signed,
						'OK-ACCESS-PASSPHRASE': PASS,
						'OK-ACCESS-TIMESTAMP': timestamp
					}
				}
			)

Expected behavior

The Path should include question mark

Environment

  • Axios Version [e.g. 1.0.0]
  • Adapter XHR
  • Browser Chrome
  • Browser Version [newest]
  • Node.js Version v18.10.0
  • OS: Windows 11
  • Additional Library Versions React 18.2

Additional context/Screenshots

Add any other context about the problem here. If applicable, add screenshots to help explain.
image

@jasonsaayman
Copy link
Member

Fixed with #5018

@marsidorowicz
Copy link
Author

Nice! What release it will be?

@jasonsaayman
Copy link
Member

Today some time working on it

@marsidorowicz
Copy link
Author

thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants