Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added generic AxiosAbortSignal TS interface to avoid importing AbortController polyfill #4229

Merged
merged 14 commits into from May 4, 2022
Merged

Added generic AxiosAbortSignal TS interface to avoid importing AbortController polyfill #4229

merged 14 commits into from May 4, 2022

Conversation

DigitalBrainJS
Copy link
Collaborator

Fixes #4124 by adding a generic AbortSignal interface.

@armandodlvr armandodlvr mentioned this pull request Nov 11, 2021
Closed
@DigitalBrainJS DigitalBrainJS mentioned this pull request Nov 30, 2021
Closed
@DigitalBrainJS
Copy link
Collaborator Author

@jasonsaayman can this be reviewed and merged to avoid subsequent issues?

@vishalailani
Copy link

@DigitalBrainJS / @jasonsaayman, i am also facing the same issue. is it merged ? if not please merge this as all checks have already passed.

@j4ys0n
Copy link

j4ys0n commented Dec 2, 2021

+1 can this be merged please? my build is failing because of the issue this fixes.

thank you!

@juditvarro
Copy link

juditvarro commented Dec 6, 2021 •
edited

+1
Could you please give an estimation @DigitalBrainJS / @jasonsaayman when can we expect that this will be merged? Thank you!

@DigitalBrainJS
Copy link
Collaborator Author

@juditvarro Unfortunately, I can't provide an estimation as I'm not a member of the Axios team. The project is maintained by @jasonsaayman and @chinesedfan, so everything is up to them.

@corrjo
Copy link

corrjo commented Dec 9, 2021

I'll be the next to nag here. @jasonsaayman @chinesedfan 🙏

@swain
Copy link

swain commented Dec 27, 2021

+1 @jasonsaayman @chinesedfan

@nyalsadiq
Copy link

Is there anything we can do to help get this merged soon? @jasonsaayman @chinesedfan

@jasonsaayman jasonsaayman merged commit 384b7e6 into axios:master May 4, 2022
@winklertomas winklertomas mentioned this pull request May 12, 2022
Merged
5 tasks
@jan-molak jan-molak mentioned this pull request Jun 2, 2022
Closed
@redpeacock78 redpeacock78 mentioned this pull request Oct 5, 2022
Merged
@girishjaju18 girishjaju18 mentioned this pull request Nov 22, 2022
Closed
@urugator urugator mentioned this pull request Nov 22, 2022
Merged
@DigitalBrainJS DigitalBrainJS mentioned this pull request Jan 31, 2024
Merged
@snykbotzup snykbotzup mentioned this pull request Mar 16, 2024
Open
@ayoshebby ayoshebby mentioned this pull request Apr 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of AbortController ist breaking for setup without DOM Library
8 participants
@DigitalBrainJS @vishalailani @j4ys0n @juditvarro @corrjo @swain @nyalsadiq @jasonsaayman