Fixing http tests to avoid hanging when assertions fail #4435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mocha tests for the
http
adapter are asynchronous and rely on Mocha'sdone
callback to be invoked on success - or failure. When it's not called, the tests hang. I identified various places wheredone
was not being called, or was called incorrectly (ie never actually being reachable).Here are two examples of handling that wasn't correct:
This PR does not fix all occurrences, but all those from cases similar to the above. A future pass should be done on tests that are event-based to make sure
done(error)
is called in the proper places.Ref: mentioned in issue #4318.