Replaced Webpack in favor of Rollup. #4596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DigitalBrainJS can you fix the merge conflcits there then i can add this soon |
…lup-build � Conflicts: � dist/axios.js � dist/axios.map � dist/axios.min.js � dist/axios.min.map � package-lock.json
This was referenced Apr 26, 2022
|
I will add this to the next version |
|
If Rollup is now the build runner, do you still require https://github.com/axios/axios/blob/v1.x/webpack.config.js to exist in repo? |
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup is better for library bundling. The rollup pipeline generates more compact code. The current minified build loses 2 KB in weight.
It still uses the old Grunt pipeline, but we will be taking small steps.
It is assumed that PR #4594 will be merged since currently client code rely on node.js 'url' module which results in build warnings.