Make AxiosError.config optional in the type definition #4665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is optional in the constructor, and not always defined.
tusbar
added a commit
to tusbar/axios-logger
that referenced
this pull request
May 3, 2022
Sometimes, axios throws an error without `error.config`, this makes sure we don’t destructure an undefined property. Related: axios/axios#4665 Fix hg-pyun#94
tusbar
added a commit
to tusbar/axios-logger
that referenced
this pull request
May 3, 2022
Sometimes, axios throws an error without `error.config`, this makes sure we don’t destructure an undefined property. Related: axios/axios#4665 Fix hg-pyun#94
hg-pyun
added a commit
to hg-pyun/axios-logger
that referenced
this pull request
May 7, 2022
Sometimes, axios throws an error without `error.config`, this makes sure we don’t destructure an undefined property. Related: axios/axios#4665 Fix #94 Co-authored-by: Haegul Pyun <phg2491@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the source, the JSdoc for
configis the following:It is assigned as such:
The type in
index.d.tsis thus incorrect and needs to be optional.