Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo and formatting, add colons #4853

Merged
merged 4 commits into from Sep 15, 2022
Merged

Fix typo and formatting, add colons #4853

merged 4 commits into from Sep 15, 2022

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Jul 15, 2022 •
edited

Hi there, first of all, thanks for axios, really great library! 馃檶

Just a quick PR to:

  1. Fix a typo I found
  2. Add colons to make the style more consistent with the other paragraphs
  3. Fix code formatting

@karlhorky karlhorky changed the title Fix typo, add colons Fix typo and formatting, add colons Jul 15, 2022
jasonsaayman
jasonsaayman approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 馃弰

@jasonsaayman jasonsaayman merged commit d57fdb6 into axios:v1.x Sep 15, 2022
@karlhorky
Copy link
Contributor Author

Thanks for the review and merge!

@karlhorky karlhorky deleted the patch-1 branch September 15, 2022 06:26
@redpeacock78 redpeacock78 mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonsaayman jasonsaayman jasonsaayman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karlhorky @jasonsaayman