Feature: Add checking ignore patterns for JSX properties name in sort-object

[hstemplewski]

What rule do you want to change?

JSX properties are missed when checking ignore rule pattern

Describe the problem

When we are using React as a framework and added perfectionist which sorts object keys, the pattern for ignore sorting does not check the JSX prop names when the object is passed directly to the component.

Code example

<Table
  //This one shouldn't be sorted
  columns={{
    firstCol: "COL 1",
    secondCol: "COL 2",
    thirdCol: "COL 3",
    fourhtCol: "COL 4"
  }}
/>

the rule is applied like:

"perfectionist/sort-objects": [
      "error",
      {
        type: "natural",
        order: "asc",
        "ignore-pattern": ["[Cc]olumn*"],
        groups: ["id", "unknown"],
        "custom-groups": {
          id: "id",
        },
      },
    ],

Additional comments

I think this one needs to be changes from

 let variableIdentifier =
        node.parent.type === 'VariableDeclarator' &&
        node.parent.id.type === 'Identifier'
          ? node.parent.id.name
          : null

to (or sth simmillar)

 let variableIdentifier =
        (node.parent.type === 'VariableDeclarator' || node.parent.type === 'JSXAttribute') &&
        node.parent.id.type === 'Identifier'
          ? node.parent.id.name
          : null

Validations

• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

[azat-io]

Thanks, that's a really good point, I'll think about how this can be fixed.