Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: ServApp names with . are breaking monitoring tables #207

Open
c0derMo opened this issue Feb 28, 2024 · 4 comments
Open

[BUG]: ServApp names with . are breaking monitoring tables #207

c0derMo opened this issue Feb 28, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@c0derMo
Copy link

c0derMo commented Feb 28, 2024

What happened?

I've created a custom ServApp with a . in the container / App name.
Afterwards, when visiting the Monitoring tab, the "Containers - Average Resources" table and the "Containers - Average Network" table show an additional column, splitting the container name at the ..

image
(Container is called Wiki.js)

What should have happened?

Container name should not be splitted and no additional column should be added.

How to reproduce the bug?

  1. Add custom ServApp with . in name.
  2. Go to Monitoring tab
  3. Observe tables

Relevant log output

No response

Other details

No response

System details

  • Cosmos Version: 0.14.6
  • Cosmos Host OS: Debian 11 running on Raspberry Pi 3B+
  • Client Browser: Vivaldi (Chromium based)
@c0derMo c0derMo added the bug Something isn't working label Feb 28, 2024
@BearTS
Copy link

BearTS commented Jun 7, 2024

I am confused, how did you manage to create a container with name as .
I always get an error

[ERROR] Rolling back changes because of -- Container creation error: Error response from daemon: Invalid container name (.), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed[OPERATION FAILED]. CHANGES HAVE BEEN ROLLEDBACK.

@c0derMo
Copy link
Author

c0derMo commented Jun 8, 2024

The full name of the container was Wiki.js, I think the first character can't be a ., but subsequent characters can, as indicated by the regex [a-zA-Z0-9][a-zA-Z0-9_.-] in the logs you posted

@BearTS
Copy link

BearTS commented Jun 8, 2024

Oh that's what you mean, let me try this locally and see if I can make a PR to fix this :)

Edit: sorry I did not see

(Container is called Wiki.js)

Gotcha

Edit 2: am able to reproduce the bug

@BearTS
Copy link

BearTS commented Jun 8, 2024

@c0derMo Made a PR which fixes the table 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants