Skip to content

Commit 9290ae4

Browse files
MichaelDeBoeyazz
andauthoredAug 21, 2020
BREAKING CHANGE: require node 10 and prettier 2 (#104)
* chore: Update dependencies * BREAKING CHANGE: Node >=10.13.0 is required * BREAKING CHANGE: Prettier ^2.0.0 is required * Run Prettier on full codebase If you are still on an older version of Node, or using Prettier v1, please stay on `pretty-quick@2`. Co-authored-by: Lucas Azzola <lucas@azzola.dev>
1 parent 9765d16 commit 9290ae4

14 files changed

+2434
-2437
lines changed
 

‎.babelrc

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
"@babel/preset-env",
55
{
66
"targets": {
7-
"node": "6.10"
7+
"node": "10.13"
88
}
99
}
1010
]
1111
]
12-
}
12+
}

‎.travis.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ cache:
66
notifications:
77
email: false
88
node_js:
9-
- '12'
10-
- '10'
11-
- '8'
9+
- 10.13
10+
- 12
11+
- node
1212
install:
1313
- yarn
1414
script:

‎README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ Runs [Prettier](https://prettier.io) on your changed files.
1414

1515
Supported source control managers:
1616

17-
* Git
18-
* Mercurial
17+
- Git
18+
- Mercurial
1919

2020
## Install
2121

‎__mocks__/prettier.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const prettierMock = {
2-
format: jest.fn().mockImplementation(input => 'formatted:' + input),
2+
format: jest.fn().mockImplementation((input) => 'formatted:' + input),
33
resolveConfig: {
4-
sync: jest.fn().mockImplementation(file => ({ file })),
4+
sync: jest.fn().mockImplementation((file) => ({ file })),
55
},
66
getSupportInfo: jest.fn().mockReturnValue({
77
languages: [

‎bin/pretty-quick.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,19 @@ const prettyQuickResult = prettyQuick(
2020
);
2121
},
2222

23-
onFoundChangedFiles: changedFiles => {
23+
onFoundChangedFiles: (changedFiles) => {
2424
console.log(
2525
`🎯 Found ${chalk.bold(changedFiles.length)} changed ${
2626
changedFiles.length === 1 ? 'file' : 'files'
2727
}.`,
2828
);
2929
},
3030

31-
onPartiallyStagedFile: file => {
31+
onPartiallyStagedFile: (file) => {
3232
console.log(`✗ Found ${chalk.bold('partially')} staged file ${file}.`);
3333
},
3434

35-
onWriteFile: file => {
35+
onWriteFile: (file) => {
3636
console.log(`✍️ Fixing up ${chalk.bold(file)}.`);
3737
},
3838

@@ -42,7 +42,7 @@ const prettyQuickResult = prettyQuick(
4242
}
4343
},
4444

45-
onExamineFile: file => {
45+
onExamineFile: (file) => {
4646
console.log(`🔍 Examining ${chalk.bold(file)}.`);
4747
},
4848
}),

‎package.json

+16-16
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"bin": "./bin/pretty-quick.js",
99
"license": "MIT",
1010
"engines": {
11-
"node": ">=8"
11+
"node": ">=10.13"
1212
},
1313
"keywords": [
1414
"git",
@@ -27,11 +27,11 @@
2727
"img"
2828
],
2929
"dependencies": {
30-
"chalk": "^2.4.2",
31-
"execa": "^2.1.0",
30+
"chalk": "^3.0.0",
31+
"execa": "^4.0.0",
3232
"find-up": "^4.1.0",
3333
"ignore": "^5.1.4",
34-
"mri": "^1.1.4",
34+
"mri": "^1.1.5",
3535
"multimatch": "^4.0.0"
3636
},
3737
"scripts": {
@@ -49,20 +49,20 @@
4949
},
5050
"prettier": "@azz/prettier-config",
5151
"peerDependencies": {
52-
"prettier": ">=1.8.0"
52+
"prettier": ">=2.0.0"
5353
},
5454
"devDependencies": {
5555
"@azz/prettier-config": "^1.0.0",
56-
"@babel/cli": "^7.6.4",
57-
"@babel/core": "^7.6.4",
58-
"@babel/preset-env": "^7.6.3",
59-
"eslint": "^5.16.0",
60-
"eslint-config-prettier": "^6.4.0",
61-
"eslint-plugin-jest": "^22.19.0",
62-
"eslint-plugin-prettier": "^3.1.1",
63-
"husky": "^3.0.9",
64-
"jest": "^24.9.0",
65-
"mock-fs": "^4.10.1",
66-
"prettier": "1.18.2"
56+
"@babel/cli": "^7.8.4",
57+
"@babel/core": "^7.9.0",
58+
"@babel/preset-env": "^7.9.0",
59+
"eslint": "^6.8.0",
60+
"eslint-config-prettier": "^6.10.1",
61+
"eslint-plugin-jest": "^23.8.2",
62+
"eslint-plugin-prettier": "^3.1.2",
63+
"husky": "^4.2.3",
64+
"jest": "^25.2.3",
65+
"mock-fs": "^4.11.0",
66+
"prettier": "2.0.2"
6767
}
6868
}

‎src/createIgnorer.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,8 @@ export default (directory, filename = '.prettierignore') => {
66
const file = join(directory, filename);
77
if (existsSync(file)) {
88
const text = readFileSync(file, 'utf8');
9-
const filter = ignore()
10-
.add(text)
11-
.createFilter();
12-
return path => filter(join(path));
9+
const filter = ignore().add(text).createFilter();
10+
return (path) => filter(join(path));
1311
}
1412

1513
return () => true;

‎src/createMatcher.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import multimatch from 'multimatch';
22
const path = require('path');
33

4-
export default pattern => {
4+
export default (pattern) => {
55
// Match everything if no pattern was given
66
if (typeof pattern !== 'string' && !Array.isArray(pattern)) {
77
return () => true;
88
}
99
const patterns = Array.isArray(pattern) ? pattern : [pattern];
10-
return file =>
10+
return (file) =>
1111
multimatch(path.normalize(file), patterns, { dot: true }).length > 0;
1212
};

‎src/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export default (
5656
.filter(cwdIgnorer)
5757
: [];
5858

59-
const wasFullyStaged = f => unstagedFiles.indexOf(f) < 0;
59+
const wasFullyStaged = (f) => unstagedFiles.indexOf(f) < 0;
6060

6161
onFoundChangedFiles && onFoundChangedFiles(changedFiles);
6262

@@ -65,7 +65,7 @@ export default (
6565
processFiles(directory, changedFiles, {
6666
check,
6767
config,
68-
onWriteFile: file => {
68+
onWriteFile: (file) => {
6969
onWriteFile && onWriteFile(file);
7070
if (bail) {
7171
failReasons.add('BAIL_ON_WRITE');

‎src/isSupportedExtension.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ const extensions = getSupportInfo().languages.reduce(
55
[],
66
);
77

8-
export default file => extensions.some(ext => file.endsWith(ext));
8+
export default (file) => extensions.some((ext) => file.endsWith(ext));

‎src/scms/git.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import * as fs from 'fs';
55

66
export const name = 'git';
77

8-
export const detect = directory => {
8+
export const detect = (directory) => {
99
if (fs.existsSync(join(directory, '.git'))) {
1010
return directory;
1111
}
@@ -24,7 +24,7 @@ const runGit = (directory, args) =>
2424
cwd: directory,
2525
});
2626

27-
const getLines = execaResult => execaResult.stdout.split('\n');
27+
const getLines = (execaResult) => execaResult.stdout.split('\n');
2828

2929
export const getSinceRevision = (directory, { staged, branch }) => {
3030
try {
@@ -69,7 +69,7 @@ export const getChangedFiles = (directory, revision, staged) => {
6969
].filter(Boolean);
7070
};
7171

72-
export const getUnstagedChangedFiles = directory => {
72+
export const getUnstagedChangedFiles = (directory) => {
7373
return getChangedFiles(directory, null, false);
7474
};
7575

‎src/scms/hg.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { dirname } from 'path';
44

55
export const name = 'hg';
66

7-
export const detect = directory => {
7+
export const detect = (directory) => {
88
const hgDirectory = findUp.sync('.hg', {
99
cwd: directory,
1010
type: 'directory',
@@ -19,7 +19,7 @@ const runHg = (directory, args) =>
1919
cwd: directory,
2020
});
2121

22-
const getLines = execaResult => execaResult.stdout.split('\n');
22+
const getLines = (execaResult) => execaResult.stdout.split('\n');
2323

2424
export const getSinceRevision = (directory, { branch }) => {
2525
const revision = runHg(directory, [

‎src/scms/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import * as hgScm from './hg';
33

44
const scms = [gitScm, hgScm];
55

6-
export default directory => {
6+
export default (directory) => {
77
for (const scm of scms) {
88
const rootDirectory = scm.detect(directory);
99
if (rootDirectory) {

‎yarn.lock

+2,392-2,393
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)
Please sign in to comment.