Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: also use .prettierignore from current working directory (#14) #58

Merged
merged 1 commit into from Jan 16, 2019
Merged

fix: also use .prettierignore from current working directory (#14) #58

merged 1 commit into from Jan 16, 2019

Conversation

jantimon
Copy link
Collaborator

@jantimon jantimon commented Jan 15, 2019 •
edited

This pull request tries to fix #14 with a zero config approach.

If the process.cwd() is not the same as the git root it will also try to load the .prettierignore file from there.

@jantimon jantimon mentioned this pull request Jan 15, 2019
Closed
azz
azz requested changes Jan 15, 2019
View reviewed changes
Copy link
Member

@azz azz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a smart approach, thanks for implementing it!

Could you add a test for this behaviour and document it in README.md? Then it should be good to ship!

@jantimon jantimon force-pushed the fix/ignore-cwd-prettierignore branch 2 times, most recently from 3be3d08 to 43c3905 Compare January 15, 2019 19:08
@jantimon jantimon force-pushed the fix/ignore-cwd-prettierignore branch from 43c3905 to db04f29 Compare January 15, 2019 19:13
@jantimon
Copy link
Collaborator Author

Added unit tests and updated the README.md

Could you please review the pull request?

azz
azz approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@azz azz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azz azz merged commit 108344a into prettier:master Jan 16, 2019
@jantimon
Copy link
Collaborator Author

Thanks for merging! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azz azz azz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.prettierignore location
2 participants
@jantimon @azz