feat: add support for glob patterns like prettier (#57) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantimon
force-pushed
the
feature/add-mini-match
branch
from
f2a9da9
to
132584f
Compare
azz
requested changes
Jan 16, 2019
|
Would you like to be added as a collaborator on this project? |
jantimon
force-pushed
the
feature/add-mini-match
branch
from
132584f
to
6866f17
Compare
|
Yeah sure 👍 I did three changes:
|
azz
reviewed
Jan 16, 2019
src/createMatcher.js
Outdated
| const path = require('path'); | ||
|
|
||
| export default pattern => { | ||
| if (typeof pattern !== 'string') { |
There was a problem hiding this comment.
I'd have to double check, but if you do pretty-quick --pattern a --pattern b, does mri make pattern equal ['a', 'b']?
There was a problem hiding this comment.
I think we should either (a) handle multiple patterns or (b) print a warning rather than ignoring multiple patterns. I have no strong feelings one way or the other :P
There was a problem hiding this comment.
I also don't mind keeping the multimatch dependency.
There was a problem hiding this comment.
I’ll take a look and let you know :)
There was a problem hiding this comment.
It supports now three cases (using multimatch)
- no patterns
- 1 pattern (string)
- n pattern (array of strings)
jantimon
force-pushed
the
feature/add-mini-match
branch
from
6866f17
to
4445098
Compare
jantimon
force-pushed
the
feature/add-mini-match
branch
from
4445098
to
ea42bac
Compare
|
@azz do you think we can merge this now? |
azz
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to filter files for a given minimatch pattern.
If no pattern is given it will work the same way it did before.
From: https://prettier.io/docs/en/cli.html
Fixes #57