Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --bail option which fails on fix (#52) #60

Merged
merged 1 commit into from Jan 17, 2019

Conversation

jantimon
Copy link
Collaborator

@jantimon jantimon commented Jan 17, 2019

Based on #53 from @josejulio.

  • Moves the success logic into prettyQuick
  • Added a new error message: '✗ File had to be prettified and prettyQuick was set to bail mode.'
  • Add unit tests

@azz and @josejulio could you please take a look?

Copy link

@josejulio josejulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Member

@azz azz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@azz azz merged commit 054e239 into prettier:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants