Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collapsedSize and buttonPositionOffset adjustments #60

Open
gweis opened this issue May 23, 2021 · 0 comments
Open

collapsedSize and buttonPositionOffset adjustments #60

gweis opened this issue May 23, 2021 · 0 comments

Comments

@gweis
Copy link

gweis commented May 23, 2021

Hi, ... very nice package.

I think I have found 3 small issues though.

  1. const offset = isReversed ? -(size - 50) : size - 50;

    this line adjust the offset by 50 pixels (hardcoded), but I think it should use collapsedSize for both

  2. https://github.com/b-zurg/react-collapse-pane/blob/master/src/components/Resizer/index.tsx#L115
    when creating the flex style for prevButtonFlex and postButtonFlex the flex-basis needs a unit, otherwise browser like chrome will ignore the applied style.

  3. The examples in https://github.com/b-zurg/react-collapse-pane/blob/master/docs/README.md pass collapseOptions as property to SplitPane, but I think the prop should be named collapse.

cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant