From 32e4d812c1e7acbc07e72e737e20108685e41e7b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hu=C3=A1ng=20J=C3=B9nli=C3=A0ng?= Date: Fri, 8 Oct 2021 16:39:40 -0400 Subject: [PATCH] revise testcase --- packages/babel-traverse/test/scope.js | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/packages/babel-traverse/test/scope.js b/packages/babel-traverse/test/scope.js index 085a92c81b07..fbe1e1586272 100644 --- a/packages/babel-traverse/test/scope.js +++ b/packages/babel-traverse/test/scope.js @@ -782,12 +782,11 @@ describe("scope", () => { expect(switchStatement.scope.hasOwnBinding("foo")).toBe(false); }); it("in while statement", () => { - const whileStatement = getPath("while (0) { var foo; }").get("body.0"); - + const whileStatement = getPath("while (0) \n var foo;").get("body.0"); expect(whileStatement.scope.hasOwnBinding("foo")).toBe(false); }); it("in do-while statement", () => { - const doWhileStatement = getPath("do { var foo; } while (0)").get( + const doWhileStatement = getPath("do \n var foo \n while(0);").get( "body.0", ); expect(doWhileStatement.scope.hasOwnBinding("foo")).toBe(false); @@ -869,19 +868,5 @@ describe("scope", () => { expect(switchStatement.scope.hasOwnBinding("foo")).toBe(true); }); }); - //todo: decide whether these statements should be scopeable and blockParent - describe("let declarations should not be registered", () => { - it("in while statement", () => { - const whileStatement = getPath("while (0) { let foo; }").get("body.0"); - - expect(whileStatement.scope.hasOwnBinding("foo")).toBe(false); - }); - it("in do-while statement", () => { - const doWhileStatement = getPath("do { let foo; } while (0)").get( - "body.0", - ); - expect(doWhileStatement.scope.hasOwnBinding("foo")).toBe(false); - }); - }); }); });