From 59fc2132e3cbfd50d2539c3deffaf9dc2754d1ed Mon Sep 17 00:00:00 2001 From: Tan Li Hau Date: Sun, 28 Jul 2019 21:47:16 +0800 Subject: [PATCH] remove finally from completion record in trystatement --- .../test/fixtures/do-expressions/finally-block/input.js | 9 +++++++++ .../fixtures/do-expressions/finally-block/options.json | 3 +++ .../test/fixtures/do-expressions/finally-block/output.js | 9 +++++++++ packages/babel-traverse/src/path/family.js | 1 - 4 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions/finally-block/input.js create mode 100644 packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions/finally-block/options.json create mode 100644 packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions/finally-block/output.js diff --git a/packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions/finally-block/input.js b/packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions/finally-block/input.js new file mode 100644 index 000000000000..8827149f32f9 --- /dev/null +++ b/packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions/finally-block/input.js @@ -0,0 +1,9 @@ +const x = do { + try { + a(); + } catch (e) { + b(); + } finally { + c(); + } +} diff --git a/packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions/finally-block/options.json b/packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions/finally-block/options.json new file mode 100644 index 000000000000..116249a4f7a7 --- /dev/null +++ b/packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions/finally-block/options.json @@ -0,0 +1,3 @@ +{ + "plugins": ["transform-block-scoping", "proposal-do-expressions"] +} diff --git a/packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions/finally-block/output.js b/packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions/finally-block/output.js new file mode 100644 index 000000000000..22a29ec91b8b --- /dev/null +++ b/packages/babel-plugin-proposal-do-expressions/test/fixtures/do-expressions/finally-block/output.js @@ -0,0 +1,9 @@ +var x = function () { + try { + return a(); + } catch (e) { + return b(); + } finally { + c(); + } +}(); diff --git a/packages/babel-traverse/src/path/family.js b/packages/babel-traverse/src/path/family.js index 0af3d2b110cb..1ed824d3789d 100644 --- a/packages/babel-traverse/src/path/family.js +++ b/packages/babel-traverse/src/path/family.js @@ -33,7 +33,6 @@ export function getCompletionRecords(): NodePath[] { } else if (this.isTryStatement()) { paths = addCompletionRecords(this.get("block"), paths); paths = addCompletionRecords(this.get("handler"), paths); - paths = addCompletionRecords(this.get("finalizer"), paths); } else if (this.isCatchClause()) { paths = addCompletionRecords(this.get("body"), paths); } else {