From 6d3cf3d45d079251d1bcb75bbf4500871de8e5ca Mon Sep 17 00:00:00 2001 From: Kai Cataldo Date: Thu, 30 Jul 2020 18:36:50 +0000 Subject: [PATCH] update: change babel-eslint-parser version mismatch error to log --- eslint/babel-eslint-parser/src/index.js | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/eslint/babel-eslint-parser/src/index.js b/eslint/babel-eslint-parser/src/index.js index 2da046b0f05f..85c8d79bdf60 100644 --- a/eslint/babel-eslint-parser/src/index.js +++ b/eslint/babel-eslint-parser/src/index.js @@ -12,19 +12,22 @@ import convert from "./convert"; import analyzeScope from "./analyze-scope"; import visitorKeys from "./visitor-keys"; -let isRunningSupportedVersion; +let isRunningMinSupportedCoreVersion = null; function baseParse(code, options) { - if (typeof isRunningSupportedVersion !== "boolean") { - isRunningSupportedVersion = semver.satisfies( + const minSupportedCoreVersion = ">=7.0.0"; + + if (typeof isRunningMinSupportedCoreVersion !== "boolean") { + isRunningMinSupportedCoreVersion = semver.satisfies( babelCoreVersion, - packageJson.peerDependencies["@babel/core"], + minSupportedCoreVersion, ); } - if (!isRunningSupportedVersion) { + // Ensure we're using a version of `@babel/core` that includes the `parse()` API. + if (!isRunningMinSupportedCoreVersion) { throw new Error( - `@babel/eslint-parser@${packageJson.version} does not support @babel/core@${babelCoreVersion}. Please upgrade to @babel/core@${packageJson.peerDependencies["@babel/core"]}`, + `@babel/eslint-parser@${packageJson.version} does not support @babel/core@${babelCoreVersion}. Please upgrade to @babel/core@${minSupportedCoreVersion}`, ); }