From 9b673e33c8816c700759ca3822a1b180226f54c7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= Date: Fri, 27 Nov 2020 15:19:05 +0000 Subject: [PATCH] Only keep assumptions used in the tests, everything else will be in other PRs --- .../src/config/validation/options.js | 16 ---------- packages/babel-core/test/assumptions.js | 29 +++++++++---------- 2 files changed, 13 insertions(+), 32 deletions(-) diff --git a/packages/babel-core/src/config/validation/options.js b/packages/babel-core/src/config/validation/options.js index 69d25f1db6f7..507b183fa07a 100644 --- a/packages/babel-core/src/config/validation/options.js +++ b/packages/babel-core/src/config/validation/options.js @@ -332,25 +332,9 @@ type EnvPath = $ReadOnly<{ export type NestingPath = RootPath | OverridesPath | EnvPath; export const assumptionsNames = new Set([ - "arrayLikeIsIterable", - "arrayIndexedIteration", - "copyReexports", - "ignoreFunctionLength", - "ignoreToPrimitiveHint", - "inheritsAsObjectCreate", - "iterableIsArray", "mutableTemplateObject", "newableArrowFunctions", - "noDocumentAll", - "objectRestNoSymbols", - "privateFieldsAsPublic", - "setClassMethods", - "setComputedProperties", - "setModuleMeta", "setPublicClassFields", - "setSpreadProperties", - "skipForOfIterationClosing", - "superAsFunctionCall", ]); function getSource(loc: NestingPath): OptionsSource { diff --git a/packages/babel-core/test/assumptions.js b/packages/babel-core/test/assumptions.js index a4e62b481f51..ad23adae50a7 100644 --- a/packages/babel-core/test/assumptions.js +++ b/packages/babel-core/test/assumptions.js @@ -34,11 +34,11 @@ describe("assumptions", () => { assumptions: { setPublicClassFields: true, }, - presets: [() => ({ assumptions: { setClassMethods: true } })], + presets: [() => ({ assumptions: { mutableTemplateObject: true } })], }).assumptions, ).toEqual({ setPublicClassFields: true, - setClassMethods: true, + mutableTemplateObject: true, // This is enabled by default newableArrowFunctions: true, }); @@ -93,7 +93,6 @@ describe("assumptions", () => { const makePlugin = () => jest.fn(api => { api.assumption("setPublicClassFields"); - api.assumption("mutableTemplateObject"); return {}; }); @@ -110,11 +109,11 @@ describe("assumptions", () => { run(plugin, { setPublicClassFields: true, - setClassMethods: false, + mutableTemplateObject: false, }); run(plugin, { setPublicClassFields: true, - setClassMethods: false, + mutableTemplateObject: false, }); expect(plugin).toHaveBeenCalledTimes(1); @@ -125,11 +124,11 @@ describe("assumptions", () => { run(plugin, { setPublicClassFields: true, - setClassMethods: false, + mutableTemplateObject: false, }); run(plugin, { setPublicClassFields: true, - setClassMethods: true, + mutableTemplateObject: true, }); expect(plugin).toHaveBeenCalledTimes(1); @@ -140,11 +139,11 @@ describe("assumptions", () => { run(plugin, { setPublicClassFields: true, - setClassMethods: false, + mutableTemplateObject: false, }); run(plugin, { setPublicClassFields: false, - setClassMethods: true, + mutableTemplateObject: true, }); expect(plugin).toHaveBeenCalledTimes(2); @@ -154,13 +153,11 @@ describe("assumptions", () => { const plugin = makePlugin(); run(plugin, { - setPublicClassFields: true, - setClassMethods: false, + mutableTemplateObject: false, }); run(plugin, { - setPublicClassFields: false, - setClassMethods: true, - mutableTemplateObject: true, + mutableTemplateObject: false, + setPublicClassFields: true, }); expect(plugin).toHaveBeenCalledTimes(2); @@ -171,10 +168,10 @@ describe("assumptions", () => { run(plugin, { setPublicClassFields: true, - setClassMethods: false, + mutableTemplateObject: false, }); run(plugin, { - setClassMethods: true, + mutableTemplateObject: true, }); expect(plugin).toHaveBeenCalledTimes(2);