babel transfrom runtime incompatible with url loader

[samMeow]

Bug Report

Current Behavior
Babel dynamic import _interopRequireWildcard function fail if imported obj/ modules is pure string (e.g. base64 encoded image), because cache (WeakMap) doesn't accept string as key (only accept object).

Input Code
Ref: #10161

Expected behavior/code
_interopRequireWildcard should take care string module (url-loader/file-loader) also.

Environment

• @babel/core": "^7.6.4"
• node 10.15
• @babel/plugin-transform-runtime: 7.6.2
• url-loader : ^2.2.0

Possible Solution
Consider a different cache mechanism (e.g. Map/ no cache for string)

[babel-bot]

Hey @samMeow! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

[nicolo-ribaudo]

If you are using webpack you shouldn't transpile modules: it will just lead to a less optimized output.

But yes, that last if should be if (cache && typeof obj === "object").

[samMeow]

Thanks for quick response. If the direction is to only cache objects, we can simply return at the top?
if (typeof obj !== 'object') return obj and skip those caching part?

[nicolo-ribaudo]

Yeah, but it should return { default: obj } instead.

[theKashey]

Yeah, but it should return { default: obj } instead.

Why? It seems to me, that it shall return a clone of the object, with additional default:obj field.