Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@babel/eslint-plugin] better no-undef; static no-undef #12798

Closed
1 task
BobVarioa opened this issue Feb 13, 2021 · 2 comments
Closed
1 task

[@babel/eslint-plugin] better no-undef; static no-undef #12798

BobVarioa opened this issue Feb 13, 2021 · 2 comments
Labels
i: enhancement i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@BobVarioa
Copy link

BobVarioa commented Feb 13, 2021

Feature Request

  • I would like to work on this feature!

Is your feature request related to a problem?
When using static properties on classes their existence doesn't get checked; no-undef doesn't work with static anything.

Describe the solution you'd like
I feel like a simple check to check if it's been defined would be sufficient.

Describe alternatives you've considered.
I don't think this is very applicable in this scenario, but maybe not including it in the first place.

Documentation, Adoption, Migration Strategy
Just a @babel/no-undef.

@babel-bot
Copy link
Collaborator

Hey @MasterOfBob777! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@JLHwung
Copy link
Contributor

JLHwung commented Feb 16, 2021

This issue was fixed in #12370, it will be shipped in Babel 7.13. no-undef will support class properties then.

@JLHwung JLHwung closed this as completed Feb 16, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 19, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: enhancement i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

No branches or pull requests

3 participants