Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chalk dependency #13728

Closed
1 task
guybedford opened this issue Sep 2, 2021 · 4 comments
Closed
1 task

Update chalk dependency #13728

guybedford opened this issue Sep 2, 2021 · 4 comments
Labels
i: enhancement i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Milestone

Comments

@guybedford
Copy link
Contributor

馃捇

  • Would you like to work on this feature?

What problem are you trying to solve?

I've just been running Babel core in Deno using JSPM import maps (https://generator.jspm.io/#W8nDwMDE7JSYlJqjkJ+n4JKal6/I4JAE4usn5xelOpjrGZrqGcCECopSi1NLdEsqC1KLk4syC0qg8gD3eyFFRwA) and there's an issue with Chalk 2.x because it mutates __proto__ which was banned by Deno in denoland/deno#4324.

Updating to Chalk 4 fixes the issue.

Describe the solution you'd like

Update to Chalk 4.

Describe alternatives you've considered

None

Documentation, Adoption, Migration Strategy

No response

@babel-bot
Copy link
Collaborator

Hey @guybedford! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@hzoo
Copy link
Member

hzoo commented Sep 2, 2021

Sounds good, can at least make a similar change to js-tokens for babel-highlight

"chalk": "^2.0.0",
"js-tokens": "condition:BABEL_8_BREAKING ? ^7.0.0 : ^4.0.0"

@JLHwung
Copy link
Contributor

JLHwung commented Sep 3, 2021

Yeah we can't bump because Babel 7 still supports Node.js 6. We can, however, fork chalk and then proxy Node.js 6 users to our chalk@2 fork like we did for chokidar: https://github.com/nicolo-ribaudo/chokidar-2

@liuxingbaoyu
Copy link
Member

#15814 Fixed in Babel 8

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: enhancement i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

No branches or pull requests

5 participants