Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: automate compat-data update #14138

Closed
1 task done
tony-go opened this issue Jan 12, 2022 · 6 comments
Closed
1 task done

chore: automate compat-data update #14138

tony-go opened this issue Jan 12, 2022 · 6 comments
Assignees
Labels
i: enhancement outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@tony-go
Copy link
Contributor

tony-go commented Jan 12, 2022

馃捇

  • Would you like to work on this feature?

What problem are you trying to solve?

Each time upstream compat-data have been updated, maintainers have to manually open a pull request.

Describe the solution you'd like

Use the same approach as https://github.com/babel/babel/blob/main/.github/workflows/update-parser-tests.yml

Having a CRON in GitHub action that will check if there are any updates on the following sources:

  • https://github.com/kangax
  • "@mdn/browser-compat-data": "^4.0.10",
  • "core-js-compat": "^3.20.2",
  • "electron-to-chromium": "^1.3.893"

Then, run existing scripts in the repo like make build-compat-data

Open a pull request!

Thanks @JLHwung, for the idea 馃檶

Describe alternatives you've considered

Didn't imagine any alternative here 馃挬.

Documentation, Adoption, Migration Strategy

No response

@babel-bot
Copy link
Collaborator

Hey @tony-go! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.

@nicolo-ribaudo
Copy link
Member

Oh this would be awesome!

@tony-go
Copy link
Contributor Author

tony-go commented Jan 21, 2022

Sorry for the wait.

I just struggle with a simple thing: get the last commit for the gh-pages branch the github API give me on older one :s 馃槶

I'll continue my journey and keep you informed.

@JLHwung
Copy link
Contributor

JLHwung commented Jan 21, 2022

You can checkout the latest compat-data somewhere, retrieve the HEAD commit SHA1 and inject it to the download-compat-data.sh, similar to how we handle test262:

- name: Get latest test262 version
id: test262
run: echo "::set-output name=sha1::$(sh ./scripts/parser-tests/get-test262-version.sh)"
- name: Update test262 commit
run: |
echo ${{ steps.test262.outputs.sha1 }} | ./scripts/parser-tests/bump-test262-version.sh

@tony-go
Copy link
Contributor Author

tony-go commented Feb 3, 2022

Hey there !

Just to say that I accomplish a few things on my side, but nothing to share atm ^^

@liuxingbaoyu
Copy link
Member

fixed in #14248

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: enhancement outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

No branches or pull requests

5 participants