Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: logical assignment not handled in super property transforms #14163

Closed
1 task done
magic-akari opened this issue Jan 17, 2022 · 1 comment 路 Fixed by #14164
Closed
1 task done

[Bug]: logical assignment not handled in super property transforms #14163

magic-akari opened this issue Jan 17, 2022 · 1 comment 路 Fixed by #14164
Labels
i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@magic-akari
Copy link
Contributor

馃捇

  • Would you like to work on a fix?

How are you using Babel?

Programmatic API (babel.transform, babel.parse)

Input code

Thanks.

Not related to this PR, but we need to add logical assignment support to super property transforms (they should have been extracted to a new helper):

class A extends B {
  async foo() {
    super.foo ??= 1;
  }
}

currently throws

Originally posted by @JLHwung in #14162 (review)

Configuration file name

No response

Configuration

No response

Current and expected behavior

currently throws error

Environment

Latest

Possible solution

No response

Additional context

No response

@babel-bot
Copy link
Collaborator

Hey @magic-akari! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants