[Bug]: generateUidIdentifierBasedOnNode with JSX returning _objectObject

[blaumeise20]

💻

• Would you like to work on a fix?

How are you using Babel?

babel-loader (webpack)

Input code

visitors: {
    JSXElement(path) {
        console.log(path.generateUidIdentifierBasedOnNode(path.node));
        // logs `_objectObject`
    }
}

Configuration file name

No response

Configuration

No response

Current and expected behavior

Logs _objectObject to the console, but should log _div when calling with <div></div>

Environment

  System:
    OS: macOS 10.15.7
  Binaries:
    Node: 17.7.2 - /usr/local/bin/node
    npm: 7.14.0 - /usr/local/bin/npm
  npmPackages:
    @babel/helper-plugin-utils: ^7.16.7 => 7.16.7 
    @babel/plugin-syntax-jsx: ^7.16.7 => 7.16.7 
    @babel/types: ^7.17.0 => 7.17.0 

Possible solution

Change

babel/packages/babel-traverse/src/scope/index.ts

Line 201 in 982175b

parts.push(node.name);

to call gatherNodeParts(node.name, parts).

Additional context

No response

[babel-bot]

Hey @blaumeise20! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.

[nicolo-ribaudo]

Thanks for the bug report!

If it is the first time that you contribute to Babel, follow these steps: (you need to have make and yarn available on your machine)

1. Write a comment there to let other possible contributors know that you are working on this bug.
2. Fork the repo
3. Run git clone https://github.com/<YOUR_USERNAME>/babel.git && cd babel
4. Run yarn && make bootstrap
5. Wait ⏳
6. Run make watch (or make build whenever you change a file)
7. Add a test in packages/babel-traverse/test/scope.js (it looks like we don't have any test for that function yet, it's only tested in transform fixtures)
8. Update the code!
9. yarn jest traverse to run the tests
10. If it is working, run make test to run all the tests
11. Run git push and open a PR!

If you have any questions, feel free to ask!

[SophonieBouye]

Hi @nicolo-ribaudo , it's still possible to work on this issue ?

[blaumeise20]

Wow, I forgot that. I will try to fix it as soon as I can!

[SophonieBouye]

Okay Nice 🚀

[AnmolBansalDEV]

Can I work on this issue?

[blaumeise20]

If you want ofc! I don't have much time anyways 😀

[SophonieBouye]

@AnmolBansalDEV are you take it?

[AnmolBansalDEV]

yes! was busy that's why couldn't reply

[AnmolBansalDEV]

hey, I went through the file, the proposed change has already been applied

[JLHwung]

@AnmolBansalDEV You are right. It has been fixed in #14648, specifically mentioned in #14648 (comment).

Closing it as it has been fixed in another PR.

[AnmolBansalDEV]

Thank you for replying, although the issue is resolved. I'm new to open source, and few weeks into it I'm feeling lost. Can you guide me please .
Thank you!

[SophonieBouye]

@AnmolBansalDEV read the contribution rules and just take a issue and work on it ;)