Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Numeric separators broken #14425

Closed
1 task
austindonisan opened this issue Apr 6, 2022 · 4 comments 路 Fixed by #14427
Closed
1 task

[Bug]: Numeric separators broken #14425

austindonisan opened this issue Apr 6, 2022 · 4 comments 路 Fixed by #14427
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: standalone

Comments

@austindonisan
Copy link

austindonisan commented Apr 6, 2022

馃捇

  • Would you like to work on a fix?

How are you using Babel?

Other (Next.js, Gatsby, vue-cli, ...)

Input code

1_1

Configuration file name

No response

Configuration

No response

Current and expected behavior

Currently throws error:

/repl.jsx: A numeric separator is only allowed between two digits. (1:1)

> 1 | 1_1
    |  ^

Expected output:

"use strict";

11;

Environment

Babel REPL version 7.17.8

Possible solution

No response

Additional context

Works in 7.17.6, broken in 7.17.7

I'm guessing #14338 broke it

@babel-bot
Copy link
Collaborator

Hey @austindonisan! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.

@nicolo-ribaudo
Copy link
Member

Wow, I'm surprised our tests didn't prevent us from breaking so badly.

@nicolo-ribaudo
Copy link
Member

I can reproduce this on the REPL, but not locally 馃

@austindonisan Do you have an example outside of the repl?

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Apr 6, 2022

Ok, I can reproduce the bug. It only affects @babel/standalone.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: standalone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants