Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: @babel/traverse 7.17.10 will remove this assign #14525

Closed
1 task
SoloJiang opened this issue May 5, 2022 · 4 comments
Closed
1 task

[Bug]: @babel/traverse 7.17.10 will remove this assign #14525

SoloJiang opened this issue May 5, 2022 · 4 comments
Labels
i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@SoloJiang
Copy link

SoloJiang commented May 5, 2022

💻

  • Would you like to work on a fix?

How are you using Babel?

Other (Next.js, Gatsby, vue-cli, ...)

Input code

var Icestore = /** @class */ (function () {
  function Icestore(config) {
      var _this = this;
      // preStore: middleware, model hooks
      this.forEachPlugin('middleware', function (middleware) {
          _this.config.redux.middlewares.push(middleware);
      });
  }

  return Icestore;
}());

Configuration file name

No response

Configuration

No response

Current and expected behavior

Current

var Icestore = /** @class */ (function () {
  function Icestore(config) {

      // preStore: middleware, model hooks
      this.forEachPlugin('middleware', function (middleware) {
          this.config.redux.middlewares.push(middleware);
      });
  }

  return Icestore;
}());

Expected

var Icestore = /** @class */ (function () {
  function Icestore(config) {
      var _this = this;
      // preStore: middleware, model hooks
      this.forEachPlugin('middleware', function (middleware) {
          _this.config.redux.middlewares.push(middleware);
      });
  }

  return Icestore;
}());

Environment

@babel/traverse 7.17.10

I rollbacked to 7.17.9, it worked.

Possible solution

No response

Additional context

No response

@babel-bot
Copy link
Collaborator

Hey @SoloJiang! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.

@JLHwung
Copy link
Contributor

JLHwung commented May 5, 2022

Can you post the Babel config? Specifically, are you using babel-plugin-minify-dead-code-elimination?

@SoloJiang
Copy link
Author

Can you post the Babel config? Specifically, are you using babel-plugin-minify-dead-code-elimination?

Yes, I used this plugin

@JLHwung
Copy link
Contributor

JLHwung commented May 5, 2022

Duplicate of babel/minify#1028.

@JLHwung JLHwung closed this as completed May 5, 2022
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

No branches or pull requests

3 participants