Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

@babel/eslint-plugin: Support ESLint 9 #16220

Closed
1 task
brettz9 opened this issue Jan 17, 2024 · 10 comments 路 Fixed by #16414
Closed
1 task

@babel/eslint-plugin: Support ESLint 9 #16220

brettz9 opened this issue Jan 17, 2024 · 10 comments 路 Fixed by #16414

Comments

@brettz9
Copy link

brettz9 commented Jan 17, 2024

馃捇

  • Would you like to work on this feature?

What problem are you trying to solve?

@babel/eslint-plugin reports an issue with ESLint 9 (alpha).

Describe the solution you'd like

Review for ESLint 9 support and update @babel/eslint-plugin 's peerDependencies to indicate support.

Describe alternatives you've considered

Ignore the warning

Documentation, Adoption, Migration Strategy

No response

@babel-bot
Copy link
Collaborator

Hey @brettz9! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.

@brettz9 brettz9 changed the title Support ESLint 9 @babel/eslint-plugin: Support ESLint 9 Jan 17, 2024
@fisker
Copy link
Contributor

fisker commented Apr 6, 2024

Need update peerDependencies for @babel/eslint-parser

"eslint": "^7.5.0 || ^8.0.0"

Blocking eslint-plugin-unicorn https://github.com/sindresorhus/eslint-plugin-unicorn/actions/runs/8579682135/job/23514924056?pr=2250#step:4:14

@nicolo-ribaudo
Copy link
Member

ESLint 9 is now stable

@nicolo-ribaudo
Copy link
Member

I published @babel/eslint-parser@7.24.5-pre.1 and @babel/eslint-plugin@7.24.5-pre.1 (both tagged as next-eslint-9 on npm) from #16414. Please try them out and report any problems!

@Pietervanhalem
Copy link

I cannot install the pre-release. Can someone help?

root@142809de69b9:/quasar-activitylog-admin# npm i @babel/eslint-parser@7.24.5-pre.1
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "condition:": condition:BABEL_8_BREAKING ? : 5.1.1-v1

npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2024-04-08T12_37_03_930Z-debug-0.log

with package.json:

{
  "name": "activitylog-admin",
  "version": "0.0.1",
  "description": "Activitylog Admin Interface",
  "productName": "Activitylog Admin",
  "author": "sawitree kalakul bloemendal",
  "private": true,
  "scripts": {
    "lint": "eslint --ext .js,.vue ./",
    "test": "echo \"No test specified\" && exit 0",
    "dev": "quasar dev",
    "build": "quasar build",
    "upgrade": "ncu --upgrade; npm i; npm update"
  },
  "dependencies": {
    "@quasar/extras": "^1.16.11",
    "ajv": "^8.12.0",
    "axios": "^1.6.8",
    "core-js": "^3.36.1",
    "date-fns": "^3.6.0",
    "dotenv": "^16.4.5",
    "inflection": "^3.0.0",
    "json-editor": "^0.7.28",
    "json-editor-vue": "^0.13.0",
    "jsondiffpatch": "^0.6.0",
    "pinia": "^2.1.7",
    "pug": "^3.0.2",
    "pug-plain-loader": "^1.1.0",
    "quasar": "^2.15.2",
    "vue": "^3.4.21",
    "vue-router": "^4.3.0"
  },
  "devDependencies": {
    "@babel/eslint-parser": "^7.24.1",
    "@quasar/app-webpack": "^3.12.4",
    "eslint": "^8.57.0",
    "eslint-config-airbnb-base": "^15.0.0",
    "eslint-plugin-import": "^2.29.1",
    "eslint-plugin-vue": "^9.24.0",
    "eslint-webpack-plugin": "^4.1.0"
  },
  "browserslist": [
    "last 10 Chrome versions",
    "last 10 Firefox versions",
    "last 4 Edge versions",
    "last 7 Safari versions",
    "last 8 Android versions",
    "last 8 ChromeAndroid versions",
    "last 8 FirefoxAndroid versions",
    "last 10 iOS versions",
    "last 5 Opera versions"
  ],
  "engines": {
    "node": ">= 12.22.1",
    "npm": ">= 6.13.4",
    "yarn": ">= 1.21.1"
  }
}

System:
OS: Linux 5.15 Debian GNU/Linux 12 (bookworm) 12 (bookworm)
Binaries:
Node: 18.19.1 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 10.2.4 - /usr/local/bin/npm
npmPackages:
@babel/eslint-parser: ^7.24.1 => 7.24.1
eslint: ^9.0.0 => 9.0.0

@nicolo-ribaudo
Copy link
Member

Whoops, my mistake 馃槄 I'll re-publish.

@nicolo-ribaudo
Copy link
Member

Can you try again with @babel/eslint-parser@7.24.5-pre.2? and @babel/eslint-plugin@7.24.5-pre.1.

@mariocampacci
Copy link

Can you try again with @babel/eslint-parser@7.24.5-pre.2? and @babel/eslint-plugin@7.24.5-pre.1.

Hi @nicolo-ribaudo installed @babel/eslint-parser@7.24.5-pre.2 with "eslint": "^9.1.1" and works like a charm!

@babel/eslint-plugin@7.24.5-pre.1 gives error:

npm ERR! Could not resolve dependency:
npm ERR! peer @babel/eslint-parser@"^7.11.0" from @babel/eslint-plugin@7.24.5-pre.1
npm ERR! node_modules/@babel/eslint-plugin
npm ERR!   dev @babel/eslint-plugin@"7.24.5-pre.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

tried installing @babel/eslint-plugin@7.24.5-pre.2, but no luck 馃槃
npm ERR! notarget No matching version found for @babel/eslint-plugin@7.24.5-pre.2

Thanks

@JLHwung
Copy link
Contributor

JLHwung commented Apr 29, 2024

The version range ^7.11.0 does not cover the pre-release versions such as 7.24.5-pre.1. From now on you can safely ignore this error - it will be resolved automatically when we release the patch version.

@nicolo-ribaudo
Copy link
Member

I can release later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants