Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run eslint on latest node in CI #4638

Closed
hzoo opened this issue Oct 1, 2016 · 1 comment
Closed

Only run eslint on latest node in CI #4638

hzoo opened this issue Oct 1, 2016 · 1 comment
Labels
help wanted outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Milestone
Better release/de...

Comments

@hzoo
Copy link
Member

hzoo commented Oct 1, 2016 •
edited

We want to use the latest version of eslint but it dropped node < 4 already.

One solution is to only run eslint on node 6? (and not on circleci either which only runs node 0.10)

I'm not sure if you just change the https://github.com/babel/babel/blob/master/.travis.yml?
@hzoo hzoo added PR: Internal 🏠 A type of pull request used for our changelog categories help wanted labels Oct 1, 2016
@ljharb
Copy link
Member

ljharb commented Oct 4, 2016

https://github.com/ljharb/is-callable/blob/master/.travis.yml as an exemplar

@gyandeeps gyandeeps mentioned this issue Oct 5, 2016
Merged
@hzoo hzoo closed this as completed in 6cfd3d9 Oct 5, 2016
@hzoo hzoo mentioned this issue Oct 11, 2016
Closed
panagosg7 pushed a commit to panagosg7/babel that referenced this issue Jan 17, 2017
@gyandeeps @panagosg7
Update: Eslint to 3.0 and update CI builds (fixes babel#4638) (babel#…
adbb1f9 
…4680)
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
Better release/development process
Development

No branches or pull requests
2 participants
@ljharb @hzoo