Bug fix #6666 #6726
Bug fix #6666 #6726
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5611/ |
existentialism
added
pkg: parser
PR: Bug Fix 🐛
| @@ -445,7 +446,7 @@ export default class Tokenizer extends LocationParser { | |||
| type = tt.exponent; | |||
| } | |||
|
|
|||
| if (next === 61) { | |||
| if (next === 61 && !exprAllowed) { | |||
There was a problem hiding this comment.
(This has nothing to do with your PR)
The char codes are very difficult to read to me since I need to lookup in the table. It's sometimes inconsistent between int or hex representation.
I would like to PR to add a constant file where the char codes are stored and replace every occurrence in Babylon. What do you think?
There was a problem hiding this comment.
This seems to be a good idea which will make the code readable. I'll make it is as a separate PR.
There was a problem hiding this comment.
I would wait for more thoughts about since, especially @danez which is the main contrib of the parse.
Actually I already started locally. I can push a PR today, we can also both work on it.
|
@rajzshkr thanks! |
lock
bot
added
the
outdated
Edit by @nicolo-ribaudo:
Old PR: babel/babylon#778