Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browserslist versions incorrectly evaluated #9954

Closed
somebody32 opened this issue May 7, 2019 · 5 comments
Closed

Browserslist versions incorrectly evaluated #9954

somebody32 opened this issue May 7, 2019 · 5 comments
Labels
i: bug i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@somebody32
Copy link

somebody32 commented May 7, 2019

Bug Report

Current Behavior
When using defaults, Chrome >= 41 as browserslist config line babel stops including IE 11 support, but calling npx browserslist or visiting the site shows that IE 11 is in the list.

Adding IE 11 explicitly to the config fixes the issue, but that is not a solution

Input Code

const str = `${1}${2}`;

Expected behavior/code
template string should be transpiled, like with just defaults in browserslist:

var str = "".concat(1, 2);

Babel Configuration (.babelrc, package.json, cli command)

defaults
Chrome >= 41
@babel-bot
Copy link
Collaborator

Hey @somebody32! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community
that typically always has someone willing to help. You can sign-up here
for an invite.

@nicolo-ribaudo
Copy link
Member

defaults is not supported yet, see #8897

@somebody32
Copy link
Author

oh, thanks @nicolo-ribaudo. So just with defaults being there now, babel just transpiles for "all" browsers?

@nicolo-ribaudo
Copy link
Member

I think that Babel currently ignores it and just targets Chrome 41.

@somebody32
Copy link
Author

I thought more about the case when browserslist field having only defaults and nothing more. I believe I'm not the only one who thought that this will limit babel from including support for dead browsers :)
I'll close this issue then, thanks!

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: bug i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

No branches or pull requests

3 participants