Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): erase default export if exporting a TS type #10019

Merged
merged 1 commit into from May 23, 2019

Conversation

airato
Copy link
Contributor

@airato airato commented May 23, 2019

Q                       A
Fixed Issues? Fixes #7640
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10853/

@nicolo-ribaudo nicolo-ribaudo added area: typescript PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels May 23, 2019
@existentialism existentialism merged commit a6392bd into babel:master May 23, 2019
Wolvereness added a commit to VelocityMSC/babel that referenced this pull request May 28, 2019
Wolvereness added a commit to VelocityMSC/babel that referenced this pull request May 28, 2019
Wolvereness added a commit to VelocityMSC/babel that referenced this pull request May 28, 2019
This also fixes enum not adding the respective declaration to the scope
during the typescript visitation.

Rewrites:

2080042 babel#9944

a6392bd babel#10019
nicolo-ribaudo pushed a commit that referenced this pull request May 29, 2019
This also fixes enum not adding the respective declaration to the scope
during the typescript visitation.

Rewrites:

2080042 #9944

a6392bd #10019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plugin-transform-typescript] Default or named exported interface result in runtime error
4 participants