Use scope for typescript export removals #10034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes enum not adding the respective declaration to the scope during the typescript visitation. Rewrites: 2080042 babel#9944 a6392bd babel#10019
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10883/ |
danez
approved these changes
May 28, 2019
nicolo-ribaudo
added
area: typescript
PR: Bug Fix 🐛
nicolo-ribaudo
approved these changes
May 28, 2019
|
@airato Does this look ok to you? |
existentialism
approved these changes
May 28, 2019
|
👍 thank you! |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites the removal of type exports to simply examine what's in the scope. This requires a fix to the
enumtransform so it adds itself to scope.Exporting an
enumbefore it appears is invalid typescript, so whether or not it's in the scope for that visitor is irrelevant.This also changes a few related test cases to use a comment
; // Otherwise-empty fileso that they will fail-fast if the output changes, rather than quietly (though not silently) create an output file.