New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix printer for explicitly inexact Flow types #10041
Fix printer for explicitly inexact Flow types #10041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a test when the compact: true
option is enabled?
@nicolo-ribaudo Added. Is this the right way how to do it? |
Also, CI failed but doesn't seem to be related (?). It's green when I run locally. Travis seems to be happy as well. |
@mrtnzlml restarted it |
Yes 馃憤 I asked for that test because when printing objects we indent, dedent, indent and dedent again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃憤 nice work @mrtnzlml!
馃 I see, is there a way how to avoid my manual indent/dedent? |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10891/ |
It is possible to pass an option to I'm merging this PR, thank you 馃槃 |
@nicolo-ribaudo Hi, when can we expect this to be released? Seems like it's still not and I just faced this bug again today. |
Closes: #10040 馃帀