flow - allow type parameter defaults in function declarations #10084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tanhauhau
commented
Jun 11, 2019
tanhauhau
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #10083 |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | 👍 |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
|
fyi @samwgoldman |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10950/ |
tanhauhau
force-pushed
the
tanlh/feat/allow-type-parameter-default-for-function-declaration
branch
from
b627142
to
ba1b9f7
Compare
tanhauhau
force-pushed
the
tanlh/feat/allow-type-parameter-default-for-function-declaration
branch
from
14d4e00
to
445cd2a
Compare
Merged
nicolo-ribaudo
added
area: flow
pkg: parser
PR: Bug Fix 🐛
| (class A { | ||
| foo<T = string>() {} | ||
| }); | ||
| declare function foo<T = string>() {} |
There was a problem hiding this comment.
Since we're in here shuffling things, can we give these tests better names so we don't have to go through this renumbering?
There was a problem hiding this comment.
i wonder how i should name it, i copied the test case from flow fixtures, should i renamed it based on their test id?
There was a problem hiding this comment.
Maybe:
default-invalid-declare-func
default-invalid-var-type
default-invalid-class-extends
🤷♂
existentialism
approved these changes
Jun 14, 2019
nicolo-ribaudo
approved these changes
Jun 15, 2019
nicolo-ribaudo
approved these changes
Jun 15, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.