New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigInt type for Flow #10091
Merged
nicolo-ribaudo
merged 4 commits into
babel:master
from
tanhauhau:tanhauhau/fix-flow-tests
Jul 3, 2019
Merged
BigInt type for Flow #10091
nicolo-ribaudo
merged 4 commits into
babel:master
from
tanhauhau:tanhauhau/fix-flow-tests
Jul 3, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11015/ |
tanhauhau
force-pushed
the
tanhauhau/fix-flow-tests
branch
from
June 15, 2019 14:54
e63494d
to
3002aa0
Compare
hmm.. running out of memory |
tanhauhau
force-pushed
the
tanhauhau/fix-flow-tests
branch
from
June 23, 2019 12:46
3002aa0
to
77dd93c
Compare
); | ||
} | ||
|
||
this.unexpected(null, `Unexpected token, expected "number"`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
this.unexpected(null, `Unexpected token, expected "number"`); | |
this.unexpected(null, `Unexpected token, expected "number" or "bigint"`); |
nicolo-ribaudo
added
area: flow
pkg: parser
PR: New Feature 🚀
A type of pull request used for our changelog categories
Spec: BigInt
labels
Jun 27, 2019
nicolo-ribaudo
approved these changes
Jun 29, 2019
existentialism
approved these changes
Jul 3, 2019
lock
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Oct 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: flow
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
pkg: parser
PR: New Feature 🚀
A type of pull request used for our changelog categories
Spec: BigInt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of #10084,
I've fixed a few several test cases for
run_babel_parser_flow_tests
and removed them from the whitelist.Fixes #1, Fixes #2