Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow "let" as name at lexical bindings #10099

Merged
merged 3 commits into from Jun 18, 2019
Merged

Disallow "let" as name at lexical bindings #10099

merged 3 commits into from Jun 18, 2019

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Jun 15, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

Spec: https://www.ecma-international.org/ecma-262/9.0/#sec-let-and-const-declarations-static-semantics-early-errors

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 15, 2019 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10953/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10948/

kaicataldo
kaicataldo reviewed Jun 15, 2019
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a test for const let = {} and let let = {}?

packages/babel-parser/src/parser/statement.js Outdated Show resolved Hide resolved
@nicolo-ribaudo nicolo-ribaudo added pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories PR: Spec Compliance 👓 A type of pull request used for our changelog categories and removed PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jun 15, 2019
@g-plane
Copy link
Contributor Author

g-plane commented Jun 15, 2019

@nicolo-ribaudo Are there anything else that should be changed?

kaicataldo
kaicataldo approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nicolo-ribaudo
Copy link
Member

I'm surprised that this didn't change any parser Test262 result

@nicolo-ribaudo nicolo-ribaudo merged commit 11fa246 into babel:master Jun 18, 2019
@g-plane g-plane deleted the disallow-binding-let branch June 18, 2019 23:31
@kaicataldo kaicataldo mentioned this pull request Jun 19, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 20, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 23, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 3, 2019
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

@existentialism existentialism existentialism approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@g-plane @babel-bot @nicolo-ribaudo @existentialism @kaicataldo